Updates from alephium project #1918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janek26
reviewed
Mar 16, 2023
| export const SESSION_DURATION = isDev ? 24 * 60 * 60 : 30 * 60 // 30 mins in prod, 24 hours in dev | ||
| export const SESSION_DURATION = isDev ? 24 * 60 : 30 // 30 mins in prod, 24 hours in dev. Note that the unit is minute, not second |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Hey Argent-X team,
Alephium’s devs here. We would like to express our gratitude for sharing your open source wallet implementation with the space. The quality of the code and the UI/UX design is truly exceptional.
We have successfully forked your wallet to support our own blockchain. While we are unable to merge most of our changes upstream due to the differences in the UTXO model and the sharding logic, we would like to submit a few relevant changes for your review and consideration. Some of these changes are proposals, so please feel free to cherry-pick or modify them as you see fit.
Given our familiarity with your codebase, if there is anything we could help in the future, please don’t hesitate to let us know.
Best regards,
Alephium’s devs
Changes
Minor fixes, updates, and suggestions from Alephium devsChecklist
Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.
Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.